Repository navigation
Add World Clock API - #14402
Merged
Merged
Add World Clock API#14402
Conversation
kennytv
reviewed
Oct 16, 2026
kennytv
left a comment
Member
There was a problem hiding this comment.
Doesn't need the experimental annotations I'd say
Warriorrrr
reviewed
Oct 16, 2026
kennytv
approved these changes
Oct 20, 2026
NonSwag
force-pushed
the
feature/world-clock-api
branch
from
October 21, 2026 07:43
c0b4c49 to
b0c8b12
Compare
Machine-Maker
requested changes
Oct 25, 2026
NonSwag
force-pushed
the
feature/world-clock-api
branch
from
October 25, 2026 09:24
b0c8b12 to
431b424
Compare
Machine-Maker
approved these changes
Oct 30, 2026
Member
|
Why Range and not NonNegative/Positive? |
Contributor
Author
Pretty much just personal preference. Most projects I contribute to, have jetbrains' annotations, so kinda my go to. |
Member
okay i suppose is not a problem but in general we try to use that for that static ranges and the Paper Util for range check later (in implementation with https://github.com/PaperMC/Paper/blob/main/paper-api/src/main/java/io/papermc/paper/util/BoundChecker.java) |
Closed
Closed
…ock-api # Conflicts: # paper-server/patches/features/0004-Entity-Activation-Range-2.0.patch # paper-server/patches/features/0013-Add-Alternate-Current-redstone-implementation.patch # paper-server/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java
Doc94
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #14086
Based on main...feature/clock-api
Notes
When
time.affects-all-worldsis enabled, changes apply to the shared global clocks.World#getTime/setTime(time of day) as those assume a 24000 tick day, which not every clock has. (should we deprecate those?)WorldCreatorclock and timeline overrides from the original branch are not included.Behavior changes
/time set <ticks>no longer changes the clokc when its event is cacneled.ClockTimeSkipEventinstead ofTimeSkipEventwhentime.affects-all-worldsis enabled.equalsandhashCodeoverrides to the vanillaTimelineso that the registry builder round-trip test can compare rebuilt timelines.TimeSkipEventextendsClockTimeSKipEventbut has its own HandlerList, soClockTimeSkipEventlisteners don't receive per-world skips. That was already the case after #13814. Should this be documented or changed?