fix(junie): stop $ARGUMENTS/$speckit-... becoming required Junie arguments by chelsealong · Pull Request #4796 · github/spec-kit

chelsealong · 2026-09-30T07:56:04Z

Junie treats every $identifier in a command body as a required named argument. The installed commands contained $ARGUMENTS and the prose $speckit-..., so Junie silently refused to run them.

Junie's post_process_command_content now:

rewrites $ARGUMENTS to Junie's free-text $prompt, and adds allowPromptArgument: true to the frontmatter (per the Junie custom-slash-commands docs);
drops the or \$speckit-...`` aside.

Tests: test_junie_argument_placeholders_adapted and test_junie_setup_leaves_no_stray_dollar_arguments. They fail without the fix (2 failed, 32 passed on the junie test file with the source reverted). With the fix, pytest tests/integrations gives 2677 passed, 5 skipped.

AI disclosure: this change was written with Claude Code (AI-assisted).

…uments Fixes github#4794

Copilot

Copilot review overview

🟡 Changes recommended

Existing or incidental allowPromptArgument: text can prevent the required frontmatter setting from being enabled.

Review effort: Balanced
Findings: 1

Open (1)

Check allowPromptArgument value before rewriting $ARGUMENTS · New

What changed in this PR

Adapts generated Junie commands to accept free-text arguments correctly.

Changes:

Rewrites $ARGUMENTS to $prompt and removes misleading $speckit-... prose.
Adds regression and generated-command coverage.

File	Description
`src/specify_cli/integrations/junie/__init__.py`	Adds Junie-specific argument adaptation.
`tests/integrations/test_integration_junie.py`	Tests placeholder rewriting and generated commands.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…pt is used AI-assisted (Claude Code).

chelsealong · 2026-09-30T13:45:15Z

Fixed in the latest commit (AI-assisted, Claude Code): _adapt_argument_placeholders now only inspects the frontmatter block and sets allowPromptArgument to true (replacing an existing value such as false, or inserting it), so body text can no longer suppress it. Added test_junie_allow_prompt_argument_false_is_enabled (fails on the previous code; tests/integrations: 2678 passed, 5 skipped).

Copilot

Copilot review overview

🟢 Approval recommended

The focused implementation addresses both reported blockers with positive and regression coverage.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Check allowPromptArgument value before rewriting $ARGUMENTS

mnriem · 2026-09-30T15:39:28Z

Please fix test & lint errors

chelsealong · 2026-09-30T15:53:43Z

AI-assisted (Claude Code): I couldn't reproduce a test or lint failure on the current head. ruff@0.15.0 check src tests passes, pytest tests/integrations gives 2678 passed, 5 skipped, and the rest of tests gives 6321 passed, 10 skipped (Linux, Python 3.x). The only red check is pytest (macos-latest, 3.13), and its log isn't readable from the fork. If a maintainer can paste the failing test name or traceback, I'll fix it. I've made no code changes.

chelsealong · 2026-09-30T15:58:09Z

AI-assisted (Claude Code): the macOS log is readable now. The single failure is tests/specify_cli/workflows/test_catalog_versions.py::test_exact_add_uses_historical_url_digest_and_requirements (workflow catalog digest check, exit code 1). It's in code this PR doesn't touch (the PR only changes the Junie integration and its test file), and the other 9187 tests pass, including all Junie tests. I made no code changes; a re-run of that job should show whether it's environment-specific.

Pin the workflow ZIP member timestamp so independently generated catalog and download fixtures remain byte-identical across DOS timestamp boundaries. Add a regression using controlled wall-clock values two seconds apart; it fails with the original helper and passes with the fixed timestamp. Production integrity checks and existing negative tests are unchanged. Validation: targeted workflow catalog and Junie tests: 78 passed; Ruff: passed. Full pytest collection: 9014 before, 9015 after. Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

The unrelated workflow archive changes violate repository scope discipline and should be split out.

Review effort: Balanced
Findings: 1

Open (1)

Move unrelated workflow archive changes to a separate PR · New

mnriem · 2026-10-01T17:24:50Z

Please address Copilot feedback

Assisted-by: Codex (autonomous)

Copilot

🟢 Approval recommended

No active review issues are recorded for the Junie argument-handling change.

No open issues 🎉

1 resolved since last review

Move unrelated workflow archive changes to a separate PR

_{Review effort: Balanced}

chelsealong · 2026-11-15T11:47:54Z

Thank you for pointing out the unrelated catalog-test change. I removed that change in 23add6a, keeping this PR focused on Junie argument placeholders. The Junie regression suite passes all 35 tests, and specify --help succeeds.

I also merged current upstream main as 265b190 and resolved the Junie test conflict while retaining both sets of regressions. The refreshed branch passes all 71 Junie and agent-configuration tests, Ruff, and CLI help.

Posted on behalf of chelsealong. Codex (model GPT-6, autonomous) implemented this follow-up, ran the checks, and drafted this summary.

Assisted-by: Codex (model: GPT-6, autonomous)

Copilot

🟡 Changes recommended

The Junie guide is missing documentation for the $prompt/allowPromptArgument adaptation and a free-text invocation example, both required for this user-visible integration change.

1 open issue

Document Junie prompt argument adaptation and invocation · New

_{Review effort: Balanced}

+        content = content.replace("$ARGUMENTS", "$prompt")
+        fm = re.match(r"\A---(\r?\n)(.*?)(\r?\n)---(?=\r?\n|\Z)", content, re.S)
+        if "$prompt" in content and fm:


chelsealong · 2026-11-15T12:22:10Z

Updated the Junie guide to explain $prompt and allowPromptArgument: true, including a /speckit-specify free-text example. git diff --check and markdownlint-cli2 passed. Posted on behalf of chelsealong. Codex (GPT-6, autonomous) authored the documentation update and drafted this reply.

Commit: 1e28250

Copilot

🟢 Approval recommended

No active review issues were identified in the Junie free-text argument compatibility changes.

1 open issue

Document Junie prompt argument adaptation and invocation

_{Review effort: Balanced}

fix(junie): avoid $ARGUMENTS/$speckit-... becoming required Junie arg…

60b4980

…uments Fixes github#4794

chelsealong requested a review from mnriem as a code owner September 30, 2026 07:56

mnriem added the triage-nice-to-have Verdict: evidence-backed fix or greenlit feature — land after review label Sep 30, 2026

mnriem requested a balanced review from Copilot September 30, 2026 13:24

Copilot started reviewing on behalf of mnriem September 30, 2026 13:25

View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

Comment thread src/specify_cli/integrations/junie/__init__.py Resolved

fix(junie): force allowPromptArgument: true in frontmatter when $prom…

dda9257

…pt is used AI-assisted (Claude Code).

mnriem requested a balanced review from Copilot September 30, 2026 14:29

Copilot started reviewing on behalf of mnriem September 30, 2026 14:29

View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

mnriem requested a balanced review from Copilot September 30, 2026 18:24

Copilot started reviewing on behalf of mnriem September 30, 2026 18:25

View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

Comment thread tests/specify_cli/workflows/test_catalog_versions.py Resolved

KSchlobohm added the author-awaiting Waiting on author response label Oct 12, 2026

RaycarlLei mentioned this pull request Oct 22, 2026

fix(integrations): pass the Junie dispatch prompt via --task #5065

Merged

4 of 5 tasks

test: keep Junie fix focused on argument handling

23add6a

Assisted-by: Codex (autonomous)

Copilot AI balanced review requested due to automatic review settings November 15, 2026 11:42

Copilot started reviewing on behalf of chelsealong November 15, 2026 11:43

View session

Copilot AI reviewed Nov 15, 2026

View reviewed changes

edenperez909-eng approved these changes Nov 15, 2026

View reviewed changes

Merge current main and preserve Junie regression coverage

265b190

Assisted-by: Codex (model: GPT-6, autonomous)

Copilot AI balanced review requested due to automatic review settings November 15, 2026 12:03

Copilot started reviewing on behalf of chelsealong November 15, 2026 12:04

View session

Copilot AI reviewed Nov 15, 2026

View reviewed changes

Comment thread src/specify_cli/integrations/junie/__init__.py

Comment on lines +147 to +149

content = content.replace("$ARGUMENTS", "$prompt")

fm = re.match(r"\A---(\r?\n)(.*?)(\r?\n)---(?=\r?\n|\Z)", content, re.S)

if "$prompt" in content and fm:

Document Junie free-text command arguments

1e28250

Copilot AI balanced review requested due to automatic review settings November 15, 2026 12:22

Copilot started reviewing on behalf of chelsealong November 15, 2026 12:22

View session

Copilot AI reviewed Nov 15, 2026

View reviewed changes

Conversation

chelsealong commented Sep 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

chelsealong commented Sep 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

mnriem commented Sep 30, 2026

Uh oh!

chelsealong commented Sep 30, 2026

Uh oh!

chelsealong commented Sep 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

mnriem commented Oct 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

chelsealong commented Nov 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

chelsealong commented Nov 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chelsealong commented Nov 15, 2026 •

edited

Loading